Skip to content

fix typo, clean up test_traceback_frame_removal#3272

Merged
jakkdl merged 1 commit intopython-trio:mainfrom
jakkdl:clean_tb
May 23, 2025
Merged

fix typo, clean up test_traceback_frame_removal#3272
jakkdl merged 1 commit intopython-trio:mainfrom
jakkdl:clean_tb

Conversation

@jakkdl
Copy link
Member

@jakkdl jakkdl commented May 22, 2025

fixes a typo that was added in #3269, and cleans up test_traceback_frame_removal which I noticed when reading the code base the other day.

@jakkdl jakkdl mentioned this pull request May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (ca218b2) to head (c8c04b6).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3272   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             127          127           
  Lines           19259        19257    -2     
  Branches         1301         1301           
===============================================
- Hits            19259        19257    -2     
Files with missing lines Coverage Δ
src/trio/_core/_tests/test_run.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@webknjaz
Copy link
Member

I'm good with the typo fix, haven't checked other changes.

@jakkdl
Copy link
Member Author

jakkdl commented May 22, 2025

The test cleanup is very simple, we now run with strict_exception_groups so we no longer need to force two exceptions in order to get an ExceptionGroup.

@jakkdl jakkdl merged commit 3029119 into python-trio:main May 23, 2025
41 of 43 checks passed
@jakkdl jakkdl deleted the clean_tb branch May 23, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants