Skip to content

Conversation

@webknjaz
Copy link
Member

@webknjaz webknjaz commented Dec 6, 2025

Fixes #3314.

@webknjaz webknjaz requested review from A5rocks and Copilot December 6, 2025 01:37
@webknjaz webknjaz self-assigned this Dec 6, 2025
@webknjaz webknjaz marked this pull request as ready for review December 6, 2025 01:42
@webknjaz
Copy link
Member Author

webknjaz commented Dec 6, 2025

This comment was marked as spam.

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Hopefully this works.

source = ["src", "**/site-packages"]
attrs-plugin = [
"tests/_trio_check_attrs_aliases.py",
"_trio_check_attrs_aliases.py",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why this? I guess this is necessary to merge the importable with the file under tests/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I took wild a guess after you said that it's "installed" separately that this might've been something that you thought wasn't working in the past. I realized it's not installed but imported through an absolute path due to PYTHONPATH being set. And so I figured it would likely confuse the path mapper so I added an explicit one.
I haven't actually tested it locally even, just wanted to see what the PR would produce. Maybe it'd work even w/o this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (d64798f) to head (ffe7261).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main        #3367         +/-   ##
====================================================
+ Coverage   99.98454%   100.00000%   +0.01546%     
====================================================
  Files            128          128                 
  Lines          19407        19407                 
  Branches        1318         1318                 
====================================================
+ Hits           19404        19407          +3     
+ Misses             1            0          -1     
+ Partials           2            0          -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@webknjaz webknjaz merged commit 5cefcd3 into python-trio:main Dec 6, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants