Attempt to fix MacOS failures on travis by increasing sleep lengths #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tests that sleep actually sleeps for the specified time started failing on Travis's MacOS builds -- we were requesting to sleep for 0.05 seconds, and woke up after ~0.11 seconds, which is a large enough overrun to break our tests. The problems started happening without any changes to our code, so pretty sure this is a Travis issue, not a Trio issue. Still, I guess we need to make these tests more robust. The approach used here is to bump up the sleep time massively from 0.05 seconds to 1.00 seconds, and then mark the relevant tests as @slow. This adds ~5 seconds to the --run-slow test suite, which is something like a 50% increase on my laptop (but proportionally less if gathering coverage etc). We can try bumping the number down again later if we need to speed things up.
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 99.24% 99.24% +<.01%
==========================================
Files 87 87
Lines 10436 10437 +1
Branches 728 728
==========================================
+ Hits 10357 10358 +1
Misses 61 61
Partials 18 18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests that sleep actually sleeps for the specified time started
failing on Travis's MacOS builds -- we were requesting to sleep for
0.05 seconds, and woke up after ~0.11 seconds, which is a large enough
overrun to break our tests. The problems started happening without any
changes to our code, so pretty sure this is a Travis issue, not a Trio
issue.
Still, I guess we need to make these tests more robust. The approach
used here is to bump up the sleep time massively from 0.05 seconds to
1.00 seconds, and then mark the relevant tests as @slow. This adds ~5
seconds to the --run-slow test suite, which is something like a 50%
increase on my laptop (but proportionally less if gathering coverage
etc). We can try bumping the number down again later if we need to
speed things up.