Make socket bind async, and related fixups #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit doesn't actually do anything to take advantage of it, but contains all the necessary test tweaks etc.
Since this can perform blocking filesystem operations.
So bind() on them doesn't block
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 99.31% 99.31% +<.01%
==========================================
Files 87 87
Lines 10469 10487 +18
Branches 728 728
==========================================
+ Hits 10397 10415 +18
Misses 56 56
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
I might also fix the issue known as #377 while I'm at it, but posting now to see
what CI says.