Combined PR to fix CI #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 3.6:
>>> RuntimeError("oops")
RuntimeError('oops',)
On Python 3.7-dev:
>>> RuntimeError("oops")
RuntimeError('oops')
We want to test how Trio handles a function decorated with @asyncio.coroutine. Previously we did this by using asyncio.sleep. But in Python 3.7, asyncio.sleep has become an async def function instead, so the test failed. Now we define our own function decorated with @asyncio.coroutine and test that, instead of making assumptions about the stdlib.
We were calling 'exit 0' to skip the tests... inside subshell parentheses (), so it was only exiting the subshell, not the overall script. Whoops. Fix that.
This was referenced Feb 13, 2018
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=========================================
+ Coverage 99.2% 99.2% +<.01%
=========================================
Files 89 89
Lines 10332 10333 +1
Branches 719 719
=========================================
+ Hits 10250 10251 +1
Misses 63 63
Partials 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have 3 independent problems breaking CI, so we need to
fix them all at once to unwedge things. This PR fixes:
workaround for Many new and bogus "nitpick" warnings when upgrading to sphinx 1.7.0 sphinx-doc/sphinx#4609