Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The combined limiter example stores and returns undefined 'limiter' #446

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

albertogomcas
Copy link
Contributor

I assume the intended object was the freshly created 'combined_limiter'

I assume the intended object was the freshly created 'combined_limiter'
@njsmith
Copy link
Member

njsmith commented Feb 21, 2018

Thanks! This change looks good to me, but one of the CI runs hit some kind of race condition (#447), so I'm going to try closing/reopening to get it to re-run.

@njsmith njsmith closed this Feb 21, 2018
@njsmith njsmith reopened this Feb 21, 2018
@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #446   +/-   ##
======================================
  Coverage    99.2%   99.2%           
======================================
  Files          89      89           
  Lines       10345   10345           
  Branches      720     720           
======================================
  Hits        10263   10263           
  Misses         61      61           
  Partials       21      21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670933e...57cd058. Read the comment docs.

Apparently this is the only way to get Jenkins to cooperate.
@njsmith
Copy link
Member

njsmith commented Feb 21, 2018

Okay, that was a bit annoying, but all sorted now, and #448 should fix that problem for good.

Thanks! As described in our contributor guide, you should get a github invitation shortly.

@njsmith njsmith merged commit 68e684c into python-trio:master Feb 21, 2018
@albertogomcas albertogomcas deleted the patch-1 branch February 21, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants