-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.0 #564
Release v0.5.0 #564
Conversation
Looks like the docs build is broken for some reason. Also looking at the release notes: it appears we forgot to mention that |
docs/source/history.rst
Outdated
work, Trio needs to know when a resource has been closed. To facilitate this, | ||
new functions have been added: :func:`trio.hazmat.notify_fd_close` and | ||
:func:`trio.hazmat.notify_socket_close`. If you're using Trio's built-in | ||
wrappers like :cls:`~trio.SocketStream` or :mod:`trio.socket`, then you don't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, this should be :class:
, not :cls:
. Not sure what I was thinking there.
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 89 89
Lines 10617 10617
Branches 747 747
=======================================
Hits 10540 10540
Misses 59 59
Partials 18 18
Continue to review full report at Codecov.
|
should be fixed |
New CHECK_DOCS error: |
Looks good, thanks! The release notes talk about the "Outcome" library, but it's called outcome. I don't think this is import enough to block the merge, so... merging. :) |
No description provided.