Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0 #564

Merged
merged 4 commits into from
Jul 20, 2018
Merged

Release v0.5.0 #564

merged 4 commits into from
Jul 20, 2018

Conversation

smurfix
Copy link
Contributor

@smurfix smurfix commented Jul 20, 2018

No description provided.

@njsmith
Copy link
Member

njsmith commented Jul 20, 2018

Looks like the docs build is broken for some reason.

Also looking at the release notes: it appears we forgot to mention that trio.hazmat.Result, Value, and Error are deprecated, so we should probably add that in.

work, Trio needs to know when a resource has been closed. To facilitate this,
new functions have been added: :func:`trio.hazmat.notify_fd_close` and
:func:`trio.hazmat.notify_socket_close`. If you're using Trio's built-in
wrappers like :cls:`~trio.SocketStream` or :mod:`trio.socket`, then you don't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, this should be :class:, not :cls:. Not sure what I was thinking there.

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #564 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          89       89           
  Lines       10617    10617           
  Branches      747      747           
=======================================
  Hits        10540    10540           
  Misses         59       59           
  Partials       18       18
Impacted Files Coverage Δ
trio/_version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a2f8b...1c7e268. Read the comment docs.

@smurfix
Copy link
Contributor Author

smurfix commented Jul 20, 2018

should be fixed

@pquentin
Copy link
Member

New CHECK_DOCS error: /home/travis/build/python-trio/trio/docs/source/history.rst:42:py:class reference target not found: trio.hazmat.Result

@pquentin
Copy link
Member

Looks good, thanks! The release notes talk about the "Outcome" library, but it's called outcome. I don't think this is import enough to block the merge, so... merging. :)

@pquentin pquentin merged commit 8b7fae6 into python-trio:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants