Fix CapacityLimiter memory leak. #576
Conversation
There was a problem hiding this comment.
Needs a newsfragment
Otherwise lgtm
Btw, if you phrase your commit message/PR description slightly differently – like "closes #XX" or "fixes #XX" – GitHub will automatically close the issue when the PR is merged. Not a big deal in any one case, but a good habit to get into.
trio/tests/test_sync.py
Outdated
|
|
||
| async with _core.open_nursery() as n: | ||
| n.start_soon(limiter.acquire) | ||
| await _core.checkpoint() # give it a chance to run the task |
There was a problem hiding this comment.
A more robust way to do this is wait_all_tasks_blocked.
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 99.27% 99.27% +<.01%
==========================================
Files 89 89
Lines 10628 10647 +19
Branches 747 747
==========================================
+ Hits 10551 10570 +19
Misses 59 59
Partials 18 18
Continue to review full report at Codecov.
|
This closes issue #548.
Also an excuse to force the tests to re-run so I can merge this.
|
Closing/reopening to tickle travis, hopefully clear #584 failures. |
Closes #548.