Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete SSLListener doc #581

Merged
merged 3 commits into from
Jul 30, 2018
Merged

complete SSLListener doc #581

merged 3 commits into from
Jul 30, 2018

Conversation

WindSoilder
Copy link
Contributor

Trying to make SSLListener doc complete, which is referred to #540 .

@njsmith
Copy link
Member

njsmith commented Jul 29, 2018

The Jenkins failure is MagicStack/immutables#7, nothing you need to worry about.

I'm going to add a period at the end of the sentence, to satisfy my nitpicking and also trigger a test re-run... hopefully this time it will pass and we can merge :-).

@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          89       89           
  Lines       10628    10628           
  Branches      747      747           
=======================================
  Hits        10551    10551           
  Misses         59       59           
  Partials       18       18
Impacted Files Coverage Δ
trio/_ssl.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0d877...25dac11. Read the comment docs.

@njsmith
Copy link
Member

njsmith commented Jul 30, 2018

Closing/open to trigger a re-test, now that #583 is merged.

@njsmith njsmith closed this Jul 30, 2018
@njsmith njsmith reopened this Jul 30, 2018
@njsmith njsmith merged commit 8a8c092 into python-trio:master Jul 30, 2018
@njsmith
Copy link
Member

njsmith commented Jul 30, 2018

Okay, finally! Sorry for those delays.

And... welcome! 🎉 🎂 No pressure, but if you'd like to keep contributing then we'd love to have you, so I'm sending you a github invite now. You can read more about this in our contributing documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants