Add CapacityLimiter.UNLIMITED #587
Conversation
Sometimes we have an API that wants a CapacityLimiter (like run_sync_soon_in_worker_thread), and we want to have unlimited capacity (for example, when putting a long-running blocking call into a background thread, like WaitForMultipleObjects or waitpid). This can be done by writing a little stub class that implements the CapacityLimiter interface, but doing this all the time is annoying. Here's a full-fledged version, available whenever you need it.
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 99.27% 99.27% +<.01%
==========================================
Files 89 89
Lines 10640 10658 +18
Branches 747 747
==========================================
+ Hits 10563 10581 +18
Misses 59 59
Partials 18 18
Continue to review full report at Codecov.
|
|
Worth trying to document why it might be needed? Or maybe mention one example? I can’t think of a short and effective explanation, and there are going to be more use cases than we can show; so maybe this is a hint that we shouldn’t and just leave it to users to understand whether this is what they need. On the other hand, this has the potential to cause some confusion and can be misused, e.g. as a shortcut not to think too hard about what limit to impose on thread spawning. |
|
You know, that's an excellent question. I spent a while trying to document when you would use this, and couldn't figure out how to do it. I guess that means it's a bad idea. Maybe we should consider allow |
Sometimes we have an API that wants a CapacityLimiter (like
run_sync_soon_in_worker_thread), and we want to have unlimited
capacity (for example, when putting a long-running blocking call into
a background thread, like WaitForMultipleObjects or waitpid). This can
be done by writing a little stub class that implements the
CapacityLimiter interface, but doing this all the time is annoying.
Here's a full-fledged version, available whenever you need it.