Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sockets #670

Merged
merged 51 commits into from
Sep 29, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
e404d40
switched to dynamic importing
jmfrank63 Sep 16, 2018
3fcd475
Added AF_APPLETALK manually to see the effect
jmfrank63 Sep 16, 2018
711e7b4
Removed AF_APPLETALK again as tests failed
jmfrank63 Sep 16, 2018
8ea86ab
imported _socket directly as socket
jmfrank63 Sep 16, 2018
268cc33
Added print for better understanding (temporarly)
jmfrank63 Sep 16, 2018
b9ee0d7
Reverted to import of socket
jmfrank63 Sep 16, 2018
7bbb52b
Dynamic updates are simply not picked up by static analysis tools
jmfrank63 Sep 16, 2018
1b50f2a
trio/socket.py : Moved to static import of names and emoved __all__
jmfrank63 Sep 19, 2018
fc666c2
Fixed import error of some constants not found on some platforms
jmfrank63 Sep 19, 2018
9217753
Finding the offending symbols 1
jmfrank63 Sep 19, 2018
1f01599
Added new name IPPROTO_SCTP to import
jmfrank63 Sep 19, 2018
b764a97
Moved new name IPPROTO_SCTP to try except block
jmfrank63 Sep 19, 2018
7118f9b
Moved new name TCP_KEEPINTVL to try except block
jmfrank63 Sep 19, 2018
6c93661
Moved new name TCP_KEEPCNT to try except block
jmfrank63 Sep 19, 2018
37afde1
Moved new name TCP_FASTOPEN to try except block
jmfrank63 Sep 19, 2018
1e438e3
Moved new name AF_LINK to try except block
jmfrank63 Sep 19, 2018
305db2d
Moved new name sethostname to try except block
jmfrank63 Sep 19, 2018
f7fe91b
Moved new name PF_SYSTEM to try except block
jmfrank63 Sep 19, 2018
fc30951
Moved new name AF_SYSTEM to try except block
jmfrank63 Sep 19, 2018
97bc5a8
Moved new name SO_USELOOPBACK to try except block
jmfrank63 Sep 19, 2018
ecdcdf2
Put all namespaces in a try except block and pull out the once that a…
jmfrank63 Sep 19, 2018
638ab9a
Pull out SOCK_STREAM
jmfrank63 Sep 19, 2018
94042ce
Fixed typo in IPPROTO_IPV6 name
jmfrank63 Sep 19, 2018
583570d
Fixed missing import on non win platforms of IPPROTO_IPV6
jmfrank63 Sep 19, 2018
6ad0d73
Fixed formatting and missing IPPROTO_SCTP on python 3.8
jmfrank63 Sep 19, 2018
c7d1391
Reverted to star import
jmfrank63 Sep 19, 2018
7fa93e8
Removed try except wrap on SO_REUSEADDR
jmfrank63 Sep 19, 2018
0c27ae2
Fixed yapf formatting
jmfrank63 Sep 19, 2018
f8ce585
moved star import to socket.py
jmfrank63 Sep 19, 2018
762cd8d
preparation for dynamic import
jmfrank63 Sep 19, 2018
bc53484
Added minimal set of socket constants
jmfrank63 Sep 20, 2018
ef2309b
static import of functions, dynamic of constants
jmfrank63 Sep 20, 2018
ca86946
static import of functions, dynamic of constants, fix test failure fo…
jmfrank63 Sep 21, 2018
8f066c1
static import of functions, dynamic of constants, fix test failure fo…
jmfrank63 Sep 21, 2018
0e690f8
static import of functions, dynamic of constants, fix test failure fo…
jmfrank63 Sep 21, 2018
66f5330
fixed typo
jmfrank63 Sep 21, 2018
9ac6d34
Moved upper case names import to socket.py and undid prior comment
jmfrank63 Sep 23, 2018
bd9a952
Merge branch 'master' into simplify_sockets
jmfrank63 Sep 24, 2018
7f142f9
added newsfragment
jmfrank63 Sep 25, 2018
39a84f7
Increased pickleshare version to 0.7.5
jmfrank63 Sep 25, 2018
2453587
Dummy to trigger CI again
jmfrank63 Sep 26, 2018
f1d45a7
10 minutes too early try again now
jmfrank63 Sep 26, 2018
2ce378d
Do not import TCP_NOTSENT_LOWAT on windows
jmfrank63 Sep 26, 2018
caead79
unnecessary code removed and definitions moved to from _socket.py to …
jmfrank63 Sep 26, 2018
ad2e09f
Merge branch 'master' into simplify_sockets
jmfrank63 Sep 27, 2018
c43ced7
removed pragma comment
jmfrank63 Sep 27, 2018
70c9fd9
Merge branch 'master' into simplify_sockets
jmfrank63 Sep 28, 2018
3b7cb99
New yapf version should fix formatting issues
jmfrank63 Sep 28, 2018
9b8dc48
Manually adjusted trio/_signals.py formatting
jmfrank63 Sep 28, 2018
4cf0c77
Merged newsfragments under a single file
jmfrank63 Sep 28, 2018
59a899d
added backticks to module names
jmfrank63 Sep 28, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion newsfragments/542.feature.rst
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* Reworked :mod:`trio` namespace construction, making it more understandable by static analysis tools. This should improve tab completion in editors, reduce false positives from pylint, and is a first step towards providing type hints.
Reworked :mod:trio, :mod:trio.testing, and :mod:trio.socket namespace construction, making them more understandable by static analysis tools. This should improve tab completion in editors, reduce false positives from pylint, and is a first step towards providing type hints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the backticks around the module names :-) It's a restructured text thing: http://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#roles

Reworked :mod:`trio`, :mod:`trio.testing`, and :mod:`trio.socket` ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, the last 1% is 99% of the work :-)

1 change: 0 additions & 1 deletion newsfragments/670.feature.rst

This file was deleted.