Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 wheel missing #253

Closed
dettmar opened this issue Mar 22, 2023 · 2 comments · Fixed by #260
Closed

Python 3.11 wheel missing #253

dettmar opened this issue Mar 22, 2023 · 2 comments · Fixed by #260
Labels
development Issue/PR: Modification in workflows, packaging, etc.

Comments

@dettmar
Copy link

dettmar commented Mar 22, 2023

Hi! I recently migrated a project from Python 3.10 to 3.11 and although everything runs well, I noticed it added about a minute extra build time in my ci/cd pipeline. It seems as if validators doesn't provide a wheel for 3.11 and I was wondering if this is on the horizon?

Unfortunately I'm not experienced doing that myself, but please let me know if I can assist with anything,.

Thanks for your effort!
@yozachar
Copy link
Collaborator

Hi @dettmar, validators 0.20.0 officially supports these:

validators/setup.py

Lines 62 to 64 in 9c35f18

'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

I've made a couple of changes and now it's:

validators/pyproject.toml

Lines 18 to 21 in e04b4e1

"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",

Few more changes need to be made before a release.

@yozachar yozachar added development Issue/PR: Modification in workflows, packaging, etc. expected Issue: Works as designed and removed expected Issue: Works as designed labels Mar 23, 2023
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 29, 2023
@yozachar
fix: source .venv/bin/active before build
447df29 
- rename `mkdocs.yml` to `mkdocs.yaml`
- same reflects in `docs/gen_docs.py`
- activates virtual environment before build

**Related items**

*Issues*

- Closes python-validators#253
- Closes python-validators#259
@yozachar yozachar mentioned this issue Mar 29, 2023
Merged
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 29, 2023
@yozachar
fix: source .venv/bin/activate before build
7737bd2 
- rename `mkdocs.yml` to `mkdocs.yaml`
- same reflects in `docs/gen_docs.py`
- activates virtual environment before build

**Related items**

*Issues*

- Closes python-validators#253
- Closes python-validators#259
@yozachar
Copy link
Collaborator

If you're using an Apline based Python image for build in CI/CD pipeline, it might slow you down.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Issue/PR: Modification in workflows, packaging, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: source .venv/bin/activate before build yozachar/pyvalidators
2 participants
@dettmar @yozachar