Updated domain validator coverage #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated domain validator to support domains that start with an underscore. These domains are quite common in the wild. For example: _jabber._tcp.gmail.com _sip._udp.apnic.net See RFC 2181, section 11, "Name syntax" and RFC 1034, section 3.5 "Preferred name syntax" for more info.
|
Looks like we need to resolve cases where a TLD starts with an underscore (invalid) vs. a subdomain starting with an underscore (valid). |
yozachar
added a commit
to yozachar/pyvalidators
that referenced
this pull request
Mar 2, 2023
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
yozachar
added a commit
to yozachar/pyvalidators
that referenced
this pull request
Mar 2, 2023
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated domain validator to support domains that start with an underscore. These domains are quite common in the wild.
For example:
_jabber._tcp.gmail.com
_sip._udp.apnic.net
See RFC 2181, section 11, "Name syntax" and RFC 1034, section 3.5 "Preferred name syntax" for more info.