Skip to content

Conversation

yozachar
Copy link
Collaborator

@yozachar yozachar commented Feb 16, 2023

  • follows google's python style guide for docstrings
  • adds flake8-docstrings as dev dependency
  • update README's workflow badge
  • improves between.py and length.py scripts
  • adapts associated test cases as well
  • makes _extremes.py a private module

@yozachar yozachar added the review PR: Can be reviewed label Feb 16, 2023
@yozachar yozachar self-assigned this Feb 16, 2023
@kvesteri
Copy link
Collaborator

Can you split this PR into smaller ones? That way it is easier to review the changes.

@yozachar
Copy link
Collaborator Author

I can, but between.py, length.py and associated tests need to go together for the tests to be successful. Let me try moving other changes.

- follows Google's python style guide for docstrings
- adds flake8-docstrings as dev dependency
- update README's workflow badge
@yozachar

This comment was marked as duplicate.

@yozachar yozachar changed the title maint: improves between.py and length.py maint: follows google's python style guide for docstrings Feb 16, 2023
@yozachar yozachar merged commit dab3a1f into python-validators:master Feb 17, 2023
@yozachar yozachar removed the review PR: Can be reviewed label Feb 17, 2023
@yozachar yozachar added the maintenance PR: Alters existing source code label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR: Alters existing source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants