-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ip_address): properly handle private is false #374
Merged
yozachar
merged 4 commits into
python-validators:master
from
grleblanc:fix-ipv4-private
May 17, 2024
Merged
fix(ip_address): properly handle private is false #374
yozachar
merged 4 commits into
python-validators:master
from
grleblanc:fix-ipv4-private
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yozachar
requested changes
May 11, 2024
VascoSch92
reviewed
May 12, 2024
yozachar
requested changes
May 14, 2024
yozachar
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the PR!
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 28, 2024
https://build.opensuse.org/request/show/1176833 by user mia + anag+factory - Update to 0.28.3 * ensure _tld.txt is in sdist and bdist gh#python-validators/validators#379 - Changes in 0.28.2: * fix: corrects a few typo gh#python-validators/validators#371 * fix(ip_address): properly handle private is false gh#python-validators/validators#374 * chore(url): allow symbols and pictographs in url gh#python-validators/validators#375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373