Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validator for sha384 hash #387

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat: add validator for sha384 hash #387

merged 1 commit into from
Jul 10, 2024

Conversation

msamsami
Copy link
Contributor

@msamsami msamsami commented Jul 8, 2024

  • Adds a new validator for the SH384 hash

@yozachar yozachar self-assigned this Jul 10, 2024
@yozachar yozachar added the enhancement Issue/PR: A new feature label Jul 10, 2024
yozachar
yozachar approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@yozachar yozachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

I hope you don't mind, tagging you in future, if people find bugs (if any) in your contribution.

@yozachar yozachar merged commit cd01b4b into python-validators:master Jul 10, 2024
17 checks passed
@msamsami
Copy link
Contributor Author

LGTM. Thank you!

I hope you don't mind, tagging you in future, if people find bugs (if any) in your contribution.

No problem! Happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yozachar yozachar yozachar approved these changes

Assignees

@yozachar yozachar

Labels
enhancement Issue/PR: A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msamsami @yozachar