-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator russian individual tax number #408
base: master
Are you sure you want to change the base?
Conversation
Hi @tabbols95, thanks for the contribution. Country specific validations must go under Please add test cases as well. |
Hi @yozachar, thank you for your feedback. I have moved the changes to the i18n directory and added tests. All tests passed successfully. Best regards, Alexander. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename this file as ru
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This then would be test_ru
.
@@ -5,6 +5,7 @@ | |||
from .fi import fi_business_id, fi_ssn | |||
from .fr import fr_department, fr_ssn | |||
from .ind import ind_aadhar, ind_pan | |||
from .inn import inn as ru_inn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could rename the function as ru_inn
directly.
This Merge Request proposes the implementation of a validation feature for the Russian Individual Taxpayer Identification Number (INN). This enhancement aims to improve the quality of user-entered data and prevent errors associated with incorrect INNs.