Validator russian individual tax number #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tabbols95, thanks for the contribution. Country specific validations must go under Please add test cases as well. |
|
Hi @yozachar, thank you for your feedback. I have moved the changes to the i18n directory and added tests. All tests passed successfully. Best regards, Alexander. |
yozachar
requested changes
Oct 30, 2024
|
Done |
yozachar
requested changes
Nov 5, 2024
| @@ -0,0 +1,53 @@ | |||
| """Inn.""" | |||
|
|
|||
| from src.validators.utils import validator | |||
There was a problem hiding this comment.
Import directly from validators, everywhere:
from validators.utils import validator| (Literal[True]): If `value` is a valid russian individual tax number. | ||
| (ValidationError): If `value` is an invalid russian individual tax number. | ||
|
|
||
| Returns: |
There was a problem hiding this comment.
Format your files. Double check your docstrings. Refer other modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Merge Request proposes the implementation of a validation feature for the Russian Individual Taxpayer Identification Number (INN). This enhancement aims to improve the quality of user-entered data and prevent errors associated with incorrect INNs.