Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins ideas for a sprint #735

Closed
19 tasks
ocefpaf opened this issue Sep 26, 2017 · 9 comments
Closed
19 tasks

Plugins ideas for a sprint #735

ocefpaf opened this issue Sep 26, 2017 · 9 comments

Comments

@ghandic
Copy link
Contributor

ghandic commented Oct 13, 2017

Just looked at https://github.com/albburtsev/Leaflet.geojsonCSS - looks similar to what I have just submitted for a pull request but in the TimestampedGeoJson Plugin. Happy to implement this wider using their layout

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 13, 2017

@ghandic That would be nice! Do you want to submit in the same PR or do you want to close that and send a new one?

@ghandic
Copy link
Contributor

ghandic commented Oct 13, 2017 via email

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 13, 2017

Awesome!

@ghandic
Copy link
Contributor

ghandic commented Oct 17, 2017

I'm going to look into https://github.com/albburtsev/Leaflet.geojsonCSS this week, should this be implemented as standard rather than a plugin?

I have implemented this in 'features.py' could deprecate the old GeoJson in favour of the GeoJsonCss? Both are in there for now

@ghandic
Copy link
Contributor

ghandic commented Oct 18, 2017

Thinking of incorporating BeafutifyMarker, ExtraMarkers into the Marker class rather than having two new classes.

I feel like I'm putting in too many PR! Haha, what do you think @ocefpaf

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 18, 2017 via email

@prusswan
Copy link
Contributor

prusswan commented Apr 4, 2018

What is needed to integrate plugins into folium? I wish it could work with arbitrary plugins (something like Plunker etc)

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 9, 2018

Closing this for now. The list of plugin is still interesting but many of those can be implemented as external plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants