Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused default_get_install_dependencies and not using the customization get_install_dependencies #305

Closed
shubhbapna opened this issue Aug 7, 2024 · 1 comment · Fixed by #310
Assignees

Comments

@shubhbapna
Copy link
Collaborator

I couldn't find any references of default_get_install_dependencies: https://github.com/search?q=repo%3Apython-wheel-build%2Ffromager%20default_get_install_dependencies&type=code (apart from the docs)

Similarly for the custom override get_install_dependencies I can't find any reference to it: https://github.com/search?q=repo%3Apython-wheel-build%2Ffromager+get_install_dependencies&type=code

It seems like we are using get_install_dependencies_of_wheel over these 2 functions: https://github.com/python-wheel-build/fromager/blob/main/src/fromager/sdist.py#L269

@dhellmann
Copy link
Member

Those older functions were the old approach. Standardizing on building the wheel then getting the installation dependencies means we can get the dependencies from pre-built wheels, too. We also found that asking for the installation dependencies from the source tree was doing a large portion of the build work in order to produce the metadata that had the answer, so we might as well just build the wheel.

I think we can delete the old functions and override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants