Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unused functions and overrides #310

Merged
merged 1 commit into from
Aug 9, 2024
Merged

cleanup: remove unused functions and overrides #310

merged 1 commit into from
Aug 9, 2024

Conversation

shubhbapna
Copy link
Collaborator

fixes #305

@shubhbapna shubhbapna requested a review from dhellmann August 8, 2024 14:01
dhellmann
dhellmann approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. We want the wheel file to reflect the correct installation dependencies, so prepare_source and build_wheel should ensure that happens.

@mergify mergify bot merged commit 414f631 into python-wheel-build:main Aug 9, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused default_get_install_dependencies and not using the customization get_install_dependencies
2 participants
@shubhbapna @dhellmann