Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect req type for certain packages in build order #356

Closed
shubhbapna opened this issue Aug 27, 2024 · 3 comments · Fixed by #406
Closed

incorrect req type for certain packages in build order #356

shubhbapna opened this issue Aug 27, 2024 · 3 comments · Fixed by #406
Assignees
@shubhbapna

Comments

@shubhbapna
Copy link
Collaborator

Downstream when we bootstrap we get 3 different install versions of numpy: 1.26.4, 2.0.0, 2.1.0 and bootstrap ends up choosing 1.26.4 as the install dependency in the constraints file it generates. However, in the build order file 1.26.4 appears as a build-system requirement and 2.1.0 appears as an install requirement
@shubhbapna
Copy link
Collaborator Author

req type is not that relevant in the build order file so we can simply remove it

@dhellmann
Copy link
Member

We could remove both the type and the why fields.

@shubhbapna shubhbapna self-assigned this Sep 9, 2024
@shubhbapna
Copy link
Collaborator Author

why was removed in #313 (fromager 0.28+)

@shubhbapna shubhbapna mentioned this issue Sep 9, 2024
Merged
@mergify mergify bot closed this as completed in #406 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhbapna shubhbapna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove type from build-order shubhbapna/fromager
3 participants
@dhellmann @shubhbapna and others