remove "why" information from build-order files #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a dependency chain field to the build-order file so we could easily tell why something was included in the build. The information was limited to the first parent that depended on each item. Since then, we have added a more complete graph file, which includes all dependencies. Removing the "why" field from the build-order file will eliminate a redundant piece of info and reduce the size of differences in those files when they are tracked by version control tools, making the differences easier to understand.
tiran
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a dependency chain field to the
build-order file so we could easily tell why
something was included in the build. The
information was limited to the first parent that
depended on each item. Since then, we have added a
more complete graph file, which includes all
dependencies. Removing the "why" field from the
build-order file will eliminate a redundant piece
of info and reduce the size of differences in
those files when they are tracked by version
control tools, making the differences easier to
understand.