Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix typings for context.py #229

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

shubhbapna
Copy link
Collaborator

part of #226

Fixes the following type errors:

src/fromager/context.py:54: error: Need type annotation for "_build_stack" (hint: "_build_stack: list[<type>] = ...")  [var-annotated]
src/fromager/context.py:55: error: Need type annotation for "_build_requirements" (hint: "_build_requirements: set[<type>] = ...")  [var-annotated]
src/fromager/context.py:62: error: Need type annotation for "_seen_requirements" (hint: "_seen_requirements: set[<type>] = ...")  [var-annotated]
src/fromager/context.py:69: error: List item 1 has incompatible type "str | None"; expected "str"  [list-item]
src/fromager/context.py:72: error: Missing type parameters for generic type "tuple"  [type-arg]
src/fromager/context.py:75: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/context.py:80: error: Missing type parameters for generic type "tuple"  [type-arg]
src/fromager/context.py:81: error: Incompatible return value type (got "bool", expected "tuple[Any, ...]")  [return-value]
src/fromager/context.py:83: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/context.py:88: error: Missing type parameters for generic type "list"  [type-arg]
src/fromager/context.py:125: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/context.py:125: note: Use "-> None" if function does not return a value

@shubhbapna shubhbapna requested review from dhellmann and tiran July 23, 2024 19:36
@dhellmann
Copy link
Member

This looks OK to me, but @tiran is the type annotation expert so I'll let him review, too.

src/fromager/context.py Show resolved Hide resolved
src/fromager/context.py Show resolved Hide resolved
@mergify mergify bot merged commit 932f249 into python-wheel-build:main Jul 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants