Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix typings for requirements_file.py #231

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

shubhbapna
Copy link
Collaborator

part of #226

Fixes the following errors:

src/fromager/requirements_file.py:29: error: Missing type parameters for generic type "dict"  [type-arg]
src/fromager/requirements_file.py:38: error: List comprehension has incompatible type List[dict[str, object]]; expected List[Environment]  [misc]
src/fromager/requirements_file.py:41: error: Argument 1 to "evaluate" of "Marker" has incompatible type "Environment"; expected "dict[str, str] | None"  [arg-type]

Need this to fix errors in dependencies.py but I am not combining the two together in one PR because dependencies.py has a lot of typing fixes

@shubhbapna shubhbapna requested review from tiran and dhellmann July 23, 2024 21:13
@tiran tiran merged commit 21034e1 into python-wheel-build:main Jul 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants