Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix typings in commands: canonicalize.py, download_sequence.py, list_overrides.py, server.py #238

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fromager/commands/canonicalize.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

@click.command()
@click.argument("dist_name", nargs=-1)
def canonicalize(dist_name: list[str]):
def canonicalize(dist_name: list[str]) -> None:
"""convert a package name to its canonical form for use in override paths"""
for name in dist_name:
print(overrides.pkgname_to_override_module(name))
2 changes: 1 addition & 1 deletion src/fromager/commands/download_sequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def download_sequence(
build_order_file: str,
sdist_server_url: str,
include_wheels: str,
):
) -> None:
"""Download a sequence of source distributions in order.

BUILD_ORDER_FILE is the build-order.json files to build
Expand Down
2 changes: 1 addition & 1 deletion src/fromager/commands/list_overrides.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@click.pass_obj
def list_overrides(
wkctx: context.WorkContext,
):
) -> None:
"""List all of the packages with overrides in the current configuration."""
for name in overrides.list_all(
wkctx.patches_dir, wkctx.envs_dir, wkctx.settings.download_source()
Expand Down
2 changes: 1 addition & 1 deletion src/fromager/commands/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def wheel_server(
wkctx: context.WorkContext,
port: int,
address: str,
):
) -> None:
"Start a web server to server the local wheels-repo"
server.update_wheel_mirror(wkctx)
t = server.run_wheel_server(
Expand Down
Loading