Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to skip building of wheel if it is exists on the wheel server #250

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

shubhbapna
Copy link
Collaborator

@shubhbapna shubhbapna commented Jul 25, 2024

fixes #235

It should be easy to toggle this option even via env variable by setting FROMAGER_BUILD_SEQUENCE_SKIP_EXISTING=true (see https://click.palletsprojects.com/en/8.1.x/options/#values-from-environment-variables:~:text=When%20using%20auto_envvar_prefix,is%20WEB_RUN_SERVER_HOST.)

I also moved start_wheel_server outside of the loop to avoid applying the update_wheel_mirror method twice per package

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but going to leave formal approval to the experts
/lgtm

@shubhbapna shubhbapna force-pushed the skip-built-wheels branch 2 times, most recently from f9fefc0 to 5ce8877 Compare July 26, 2024 21:14
@shubhbapna
Copy link
Collaborator Author

As discussed, i have renamed the option to match what twine uses: https://twine.readthedocs.io/en/latest/#twine-upload

Also made the resolve_wheel function public

Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

src/fromager/commands/build.py Show resolved Hide resolved
@shubhbapna shubhbapna requested a review from dhellmann July 31, 2024 15:58
@mergify mergify bot merged commit 7fe89cb into python-wheel-build:main Jul 31, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add option to build-sequence to only build wheels that do not exist on the wheel server
3 participants