add GenericProvider for resolving versions #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
force-pushed
the
map-version-resolver
branch
from
d807d77 to
9165f37
Compare
tiran
reviewed
Jul 29, 2024
dhellmann
force-pushed
the
map-version-resolver
branch
5 times, most recently
from
6ac13d0 to
c149502
Compare
Refactor existing resolvers to define base classes to reduce duplication and make it easier to create new providers. Add a GenericProvider class that accepts a callable as argument and picks versions from the return values.
dhellmann
force-pushed
the
map-version-resolver
branch
from
c149502 to
73bbd9d
Compare
shubhbapna
reviewed
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor existing resolvers to define base classes
to reduce duplication and make it easier to create
new providers.
Add a GenericProvider class that accepts a
callable as argument and picks versions from the
return values.