bug: fix installation of dependency by using the resolved_version instead of actual_version #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhbapna
force-pushed
the
fix-safe-install
branch
from
616a7fd to
501284a
Compare
…of actual_version
shubhbapna
force-pushed
the
fix-safe-install
branch
from
501284a to
8ea26a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that dependencies that were resolving to some different version were not actually being installed using that version. Here is my analysis of the bug:
_maybe_install is called after handling each requirement. If the resolved version is not none, then it checks whether the actual version matches the resolved version and if it doesn't then it installs it using safe_install but in
_maybe_installit seems like we are passing the old requirement tosafe_installinstead of the resolved one: https://github.com/python-wheel-build/fromager/blob/main/src/fromager/sdist.py#L514