Fix type annotations of resolve_dist()
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sources.resolve_dist()` function returns `tuple[str | None, Version]`, not `tuple[str, str]`. The fix will allow me to enable type checking in our builder repo. See: python-wheel-build#226 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
typing-resolve_dist
branch
from
156654b to
2e7ce19
Compare
dhellmann
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sources.resolve_dist()function returnstuple[str | None, Version], nottuple[str, str]. The fix will allow me to enable type checking in our builder repo.See: #226