Improve coverage reporting #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
coverage
branch
3 times, most recently
from
74feee3 to
f567e56
Compare
dhellmann
reviewed
Aug 26, 2024
shubhbapna
reviewed
Aug 26, 2024
dhellmann
reviewed
Aug 26, 2024
There was a problem hiding this comment.
This version looks good. @shubhbapna had some comments, so I'll leave it open for him to approve and merge.
shubhbapna
reviewed
Aug 26, 2024
- Add `cov.pth` file and `COVERAGE_PROCESS_START` to track coverage of subprocesses and e2e tests - e2e tests set `COVERAGE_PROCESS_START` and run `command_pre` hooks - Configure mapping of file paths for coverage - Add step to combine coverage results in GHA - Use plain `coverage` instead of `pytest-cov`. The pytest plugin interfers with parallel coverage collection. - Fix `test_dependencies` to actually run tests Signed-off-by: Christian Heimes <cheimes@redhat.com>
shubhbapna
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cov.pthfile andCOVERAGE_PROCESS_STARTto track coverage ofsubprocesses and e2e tests
COVERAGE_PROCESS_STARTand runcommand_prehookscoverageinstead ofpytest-cov. The pytest plugininterfers with parallel coverage collection.
test_dependenciesto actually run tests