Fix: enable loopback device in network isolation #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
run-network-isolation
branch
from
735831a to
938e4f9
Compare
Some software like OpenMPI's `mpicc` do not work correctly without a loopback device. Replace the `unshare` call with a wrapper script that combines `unshare -rn` and `ip link set lo up` before `exec`-ing the final command. `unshare` is a `util-linux-core` command and therefore available pretty much in all Linux distributions. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
run-network-isolation
branch
from
938e4f9 to
0ab9db0
Compare
dhellmann
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some software like OpenMPI's
mpiccdo not work correctly without a loopback device. Replace theunsharecall with a wrapper script that combinesunshare -rnandip link set lo upbeforeexec-ing the final command.unshareis autil-linux-corecommand and therefore available pretty much in all Linux distributions.