Refactor constraints module #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
refactor-constraints
branch
from
8aa89b9 to
70d6955
Compare
tiran
force-pushed
the
refactor-constraints
branch
from
70d6955 to
28d5be0
Compare
dhellmann
reviewed
Jan 23, 2025
Refactor and modify the API of `fromager.constraints` module to prepare the code for multiple constraints files. The `Constraints` class no longer takes an mapping of package name to `Requirement`. Instead it has a new method `add_constraint()` that takes a requirements strings. The method does not take a `Requirements` object, because we might want to modify and merge constraints in the future. The `load()` module-level function has been replaced by `Constraints.load_constraints_file()` method. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
refactor-constraints
branch
from
28d5be0 to
a3cf190
Compare
dhellmann
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and modify the API of
fromager.constraintsmodule to prepare the code for multiple constraints files.The
Constraintsclass no longer takes an mapping of package name toRequirement. Instead it has a new methodadd_constraints()that takes one or more requirements strings. The method does not takeRequirementsobject, because we might want to modify and merge constraints in the future.The
load()module-level function has been replaced byConstraints.load_constraints_file()method.