feat: Add option to ignore wheel platform in resolver #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package can now ignore the upstream wheels' platforms when looking up distributions without an sdist on PyPI. The option only applies to packages that have `resolver_dist.include_wheels` enabled. The flag allows to package versions that neither provide a sdist nor a binary wheel for the current platform, e.g. Torch builds on ppc64le. Torch does neither upload sdists nor does it provide ppc64le wheels on PyPI. Fixes: python-wheel-build#556 Signed-off-by: Christian Heimes <cheimes@redhat.com>
rd4398
reviewed
Jul 3, 2025
Contributor
rd4398
left a comment
rd4398
left a comment
There was a problem hiding this comment.
Nice!
This looks good! I will leave it to @dhellmann for final approval
dhellmann
approved these changes
Jul 3, 2025
Member
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
We discussed my concerns about how we will use this downstream, and @tiran pointed out that most of the packages have sdists, so we won't have to have a configuration file for everything that is being built for the CPU architectures that do not have wheels published. We agreed if we started to accumulate a lot of config for packages with only this new flag enabled, we would come back and add a global flag to change the default setting.
| </head> | ||
| <body> | ||
| <h1>Links for fromager</h1> | ||
| <a href="https://files.pythonhosted.org/packages/7c/06/620610984c2794ef55c4257c77211b7a625431b380880c524c2f6bc264b1/fromager-0.51.0-cp311-abi3-manylinux_2_28_plan9.whl" >fromager-0.51.0-cp311-abi3-manylinux_2_28_plan9.whl</a> |
LalatenduMohanty
approved these changes
Jul 3, 2025
Member
LalatenduMohanty
left a comment
LalatenduMohanty
left a comment
There was a problem hiding this comment.
I am late to approve this , but looks good to me. This is going to be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package can now ignore the upstream wheels' platforms when looking up distributions without an sdist on PyPI. The option only applies to packages that have
resolver_dist.include_wheelsenabled.The flag allows to package versions that neither provide a sdist nor a binary wheel for the current platform, e.g. Torch builds on ppc64le. Torch does neither upload sdists nor does it provide ppc64le wheels on PyPI.
Fixes: #556