This repository has been archived by the owner on Nov 23, 2017. It is now read-only.
Do not connect UDP sockets when broadcast is allowed #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue python#480. The _SelectorDatagramTransport.sendto method has to be modified so _sock.sendto is used in all cases (since there is no proper way to tell if the socket is connected or not). Could that be an issue for connected sockets?
vxgmichel
force-pushed
the
issue-480
branch
2 times, most recently
from
6855e7e to
6bef745
Compare
added 2 commits
February 16, 2017 14:28
This might happen on Windows if the socket is not connected (e.g. for UDP broadcasting)
vxgmichel
force-pushed
the
issue-480
branch
2 times, most recently
from
132fb64 to
6b501a9
Compare
|
Please reopen this PR at https://github.com/python/cpython. This repo is going to be deleted soon. |
|
No problem, moved to python/cpython#423. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #480, as explained in this comment.
The
_SelectorDatagramTransport.sendtomethod has to be modified so_sock.sendtois used in all cases (because there is no proper way to tell if the socket is connected or not). Could that be anissue for connected sockets?