Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual precise Python version @ coverage flags #507

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

webknjaz
Copy link
Contributor

The matrix factor for the Python version is imprecise and doesn't always contain characters suitable for Codecov flags. actions/setup-python@v4 now provides an output specifying exactly what's been installed based on the request. This value is perfect for use in flags. This patch implements just that.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Sep 28, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #507 (f4d34ea) into main (bc5e840) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1828      1828           
  Branches       223       211   -12     
=========================================
  Hits          1828      1828           
Flag Coverage Δ
Python_3.10 ?
Python_3.10.7 100.00% <ø> (?)
Python_3.11-dev ?
Python_3.11.0-rc.2 100.00% <ø> (?)
Python_3.8 ?
Python_3.8.14 100.00% <ø> (?)
Python_3.9 ?
Python_3.9.14 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ezio-melotti
Copy link
Member

ezio-melotti commented Oct 1, 2022

This change creates duplicated entries in the table included in the previous message, with the matrix versions showing ? and the actual versions showing the right coverage. Is this something that can be fixed?

On codecov only the actual versions are included.

@webknjaz
Copy link
Contributor Author

webknjaz commented Oct 4, 2022

@ezio-melotti

On codecov only the actual versions are included.

Looks like that comment includes historic flags that existed before this PR, showing that this PR's workflow jobs didn't report anything with those flags. I'm going to guess that it compares what changed vs main and that's why they are in the table. I suppose they should disappear once there's a commit on master that no longer reports those flags.

@hugovk
Copy link
Member

hugovk commented Oct 4, 2022

So (for example) Python_3.9 is the old one and Python_3.9.14 is the new one.

Do we actually care about the patch version in the coverage history?

That is, when checking the coverage, do we want continuous history across all 3.9 versions or does it not matter?

@webknjaz
Copy link
Contributor Author

That is, when checking the coverage, do we want continuous history across all 3.9 versions or does it not matter?

I think this may be an important bit of information. Especially, if there's some conditional behavior/hacks that are only triggered on some patch versions. This might prove useful in future archeology while debugging stuff.

@hugovk
Copy link
Member

hugovk commented Oct 17, 2022

Fair enough! I suppose we could even send x.y and x.y.z flags, but will leave it up to you.

@webknjaz
Copy link
Contributor Author

There's no easy way to infer that x.y version without resorting to an extra task. This is because the matrix values aren't always suitable for flags.

@ezio-melotti ezio-melotti merged commit b2cbfc0 into python:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants