Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sentry-sdk from 1.11.1 to 1.12.1 #525

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2023

Bumps sentry-sdk from 1.11.1 to 1.12.1.

Release notes

Sourced from sentry-sdk's releases.

1.12.1

Various fixes & improvements

1.12.0

Basic OTel support

This adds support to automatically integrate OpenTelemetry performance tracing with Sentry.

See the documentation on how to set it up: https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/

Give it a try and let us know if you have any feedback or problems with using it.

By: @​antonpirker (#1772, #1766, #1765)

Various fixes & improvements

Changelog

Sourced from sentry-sdk's changelog.

1.12.1

Various fixes & improvements

1.12.0

Basic OTel support

This adds support to automatically integrate OpenTelemetry performance tracing with Sentry.

See the documentation on how to set it up: https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/

Give it a try and let us know if you have any feedback or problems with using it.

By: @​antonpirker (#1772, #1766, #1765)

Various fixes & improvements

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.11.1 to 1.12.1.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@1.11.1...1.12.1)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 1, 2023
@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #525 (35d1c11) into main (49e18cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #525   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2034      2034           
  Branches       231       231           
=========================================
  Hits          2034      2034           
Flag Coverage Δ
Python_3.10.8 ?
Python_3.10.9 100.00% <ø> (?)
Python_3.11.0 ?
Python_3.11.1 100.00% <ø> (?)
Python_3.12.0-alpha.2 ?
Python_3.12.0-alpha.3 100.00% <ø> (?)
Python_3.8.14 ?
Python_3.8.15 100.00% <ø> (?)
Python_3.9.15 ?
Python_3.9.16 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ezio-melotti ezio-melotti merged commit 16b5d84 into main Jan 1, 2023
@dependabot dependabot bot deleted the dependabot/pip/sentry-sdk-1.12.1 branch January 1, 2023 10:13
@CAM-Gerlach
Copy link
Member

It's pretty noisy to have dependabot open 6 PRs at once, each just changing one dependency (even though it perhaps is more atomic). It also means the new dependencies aren't all tested together, as opposed to individually (which allows detecting dependency-specific issues, but does not actually test the final composed product of all of the updates until the final PR is merged). Is it possible to have dependabot submit one PR with all the updates at the designated interval? It wasn't clear from skimming the docs whether that is possible.

@AlexWaygood
Copy link
Member

Is it possible to have dependabot submit one PR with all the updates at the designated interval?

Unfortunately not. dependabot/dependabot-core#1190 is the number-1 upvoted dependabot issue; you're not the only one to have wanted this.

@CAM-Gerlach
Copy link
Member

Ah, I see, thanks. I also realized something more important when I wondered how I got subscribed to all notifications in this repo in the first place...apparently (perhaps due to python/core-workflow#460 ) I have Write permissions here, which subscribes you automatically, and it seems that none of the branch protection steps were implemented, so I (and I assume any other triager) can merge PRs, push branches, etc. willy nilly. That should be fixed by an admin here...maybe @Mariatta can help? I've listed the steps needed on that issue.

@Mariatta
Copy link
Member

Mariatta commented Jan 1, 2023

I don't have admin privs on the bedevere repo. Perhaps @brettcannon ?

@hugovk
Copy link
Member

hugovk commented Jan 1, 2023

It also means the new dependencies aren't all tested together, as opposed to individually (which allows detecting dependency-specific issues, but does not actually test the final composed product of all of the updates until the final PR is merged).

Dependabot (sometimes? always?) rebases PRs after others are merged, so they do end up getting tested together. For example, see the force pushes to #524.

Is it possible to have dependabot submit one PR with all the updates at the designated interval?

No, but I use Renovate on my projects, which can be configured to create a single, grouped PR. For example: hugovk/pypistats#368 / https://github.com/hugovk/pypistats/blob/main/.github/renovate.json

@ezio-melotti
Copy link
Member

Dependabot (sometimes? always?) rebases PRs after others are merged, so they do end up getting tested together.

IIUC she rebases when a previous change (e.g. to requirements.txt) creates a merge conflict. With small dependency files this happens quite often, but if it doesn't, it's also possible to explicitly request a rebase with @dependabot rebase.

Having multiple PRs is good because sometimes you don't want to merge them all (e.g. in case one of the dependencies has breaking changes or issues).

@brettcannon
Copy link
Member

I don't have admin privs on the bedevere repo. Perhaps @brettcannon ?

Nope, I'm not an admin.

@CAM-Gerlach
Copy link
Member

Okay, thanks. Then I guess @python/organization-owners ? It would have had to be an admin to make the change in the first place...

@brettcannon
Copy link
Member

Okay, thanks. Then I guess @python/organization-owners ? It would have had to be an admin to make the change in the first place...

I think you can also email admin at python for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants