Skip to content

Make Bedevere showing label names like GitHub does #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Make Bedevere showing label names like GitHub does #361

merged 3 commits into from
Feb 16, 2023

Conversation

arhadthedev
Copy link
Member

Currently Bedevere prints raw label names:

Note that a label is spelled as raw :hammer: test-with-refleak-buildbots. However, the label selector shows it differently:

This PR fixed the raw output of code blocks with a manual rendering of this exact emoticon. Thanks to it the message will look like this (simulated with Chrome Developer Tools):

@arhadthedev
Copy link
Member Author

@zware

@hugovk
Copy link
Member

hugovk commented Feb 16, 2023

Thanks for this, it was bugging me recently too :)

Rather than using code formatting, does it look better with the <kbd> tag?

So instead of:

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

Like this:

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

It works with either of these:

<kbd>:hammer: test-with-refleak-buildbots</kbd>

<kbd>🔨 test-with-refleak-buildbots</kbd>

@arhadthedev
Copy link
Member Author

@hugovk Thank you, it made the patch extremely compact.

@zware zware merged commit 5283711 into python:main Feb 16, 2023
@arhadthedev arhadthedev deleted the tags-with-github-emoticons branch February 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants