Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnixNoGilRefleakBuild.testFlags #417

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 4, 2023

It must be a list, no a string.

Correctly, the builder fails with:

./python -E  -m test --slow-ci --timeout=12000 - R   3 : 3   - u - c p u --junit-xml test-results.xml -j2 --fail-rerun
regrtest.py: error: unrecognized arguments: -

It must be a list, no a string.

Correctly, the builder fails with:

    ./python -E  -m test --slow-ci --timeout=12000 - R   3 : 3   - u - c p u --junit-xml test-results.xml -j2 --fail-rerun
    regrtest.py: error: unrecognized arguments: -
@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2023

cc @itamaro: I made changes recently, maybe your PR landed "while" I was doing these changes.

@vstinner vstinner enabled auto-merge (squash) October 4, 2023 12:38
@vstinner vstinner merged commit fcb15d0 into python:main Oct 4, 2023
1 check passed
@vstinner vstinner deleted the fix_nogil_refleak branch October 4, 2023 12:40
@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2023

Example of builder failure: https://buildbot.python.org/all/#/builders/1226/builds/228

@itamaro
Copy link
Contributor

itamaro commented Oct 4, 2023

Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants