-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a WASI pydebug builder #456
Conversation
@brettcannon, are you ready for this to be deployed? |
I realized over the weekend I need to figure out how to migrate to wasmtime 14+, so not quite. 😅 I'll get an update to this PR and ping you when it's ready to go. |
@zware OK, hopefully we're all good now. I took the simplest route and disabled the warning from using the old CLI. Eventually, though, I will probably need to explicitly specify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall change LGTM, but the person who will merge the PR will have to check buildbot server logs to double check that the new config is deployed correctly ;-) Sadly, that's the only reliable test (and I'm fine with it, it's not a big deal.)
I turned this to draft while I investigate https://buildbot.python.org/all/#/builders/1046/builds/4077/steps/11/logs/stdio to see if it's from my upgrade to wasmtime 16 or because this hasn't been merged yet. |
Turns out it was a bug in wasmtime (bytecodealliance/wasmtime#7813). I downgraded the version on the buildbot to 14.0.4, so this PR should be good to go! |
PR merged, let's see how it goes. |
It's kind of surprising that "wasm32-wasi" builder keeps its history, and switched from Release build to Debug build. I scheduled manually a new build, so a Debug build: https://buildbot.python.org/all/#/builders/1046/builds/4086 So far, Python is building, it looks fine (the job was scheduled properly). Good good. Nice work @brettcannon! |
@brettcannon: Build failed at Simplified output:
|
#461 should (hopefully) fix it. Turns out I had a typo in a path. I'm surprised Buildbot didn't show an error for changing the cwd to one that didn't exist, but maybe it creates it automatically? |
I see that "wasm32-wasi 3.x" is back to green and it's a debug build. Example of a recent build: https://buildbot.python.org/all/#/builders/1046/builds/4127 Extract of test.pythoninfo:
Tests headers:
Congrats @brettcannon, it works as expected! |
Requires 3.13+.