Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proposing #147 I noticed that mypy failed with missing
types-request
- and while the mypy configuration had the--install-types
, it did not work automatically for requests.The error was:
I looked a bit closer and noticed the advice from
https://github.com/pre-commit/mirrors-mypy
This PR fixes the problem by removing
--install-types
and installing types-requests explicitly as additional-dependencies.starting