Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust coverage failure threshold #21

Closed
brettcannon opened this issue Feb 11, 2017 · 1 comment
Closed

Adjust coverage failure threshold #21

brettcannon opened this issue Feb 11, 2017 · 1 comment

Comments

@brettcannon
Copy link
Member

Codecov lets us specify how much of a coverage drop is acceptable. Since we are seeing some PRs fail by just adding an extra comment line, we should probably set a threshold of some sort to say a slight drop is acceptable. I'm thinking maybe 0.01% is okay?

And the configuration can be validated.

@zware
Copy link
Member

zware commented Feb 11, 2017

There is also some random noise in the coverage results that we might need to track down and mitigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants