Skip to content

Link to GitHub PR from bpo emails #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mariatta opened this issue Feb 18, 2017 · 4 comments
Closed

Link to GitHub PR from bpo emails #35

Mariatta opened this issue Feb 18, 2017 · 4 comments

Comments

@Mariatta
Copy link
Member

When someone creates a pull request that links to a bpo issue, there would be email sent to the issue subscribers / nosy list, for example:

Changes by Mariatta Wijaya <mariatta.wijaya@gmail.com>:


----------
pull_requests: +70
  1. Does 70 here refer to GitHub pull request number 70? (eg Add Travis CI and Codecov badges to README cpython#70)
  2. Instead of a plaintext +70, can it be a link to the said pull request?

Thanks :)

@ezio-melotti
Copy link
Member

  1. The 70 only refers to pull_request item of the tracker, i.e. https://bugs.python.org/pull_request70
    The actual PR number is different, as you can see from the link (in this case is bpo-29481: add versionadded 3.6.1 to typing.Deque docs cpython#107).
  2. These mails are automatically generated, and I'm not aware of a way to change them and insert the link. It should be possible, but probably it's not too straightforward, and it might not be worth the effort.

@Mariatta
Copy link
Member Author

Mariatta commented Mar 6, 2017

Thanks for the info, @ezio-melotti
If there's no straightforward way to do it, then let's not bother for now.

@Mariatta Mariatta closed this as completed Mar 6, 2017
@ncoghlan
Copy link
Contributor

ncoghlan commented Apr 1, 2017

I'm reopening this, as the status quo is genuinely confusing when one PR references multiple issues - each email has a different numeric identifier for the PR, even if they're all related to the same PR. (I'd be surprised if it ever happens again to the degree it did when the draft NEWS generation PR was closed, but I'd also be surprised if it never happens at all)

Rather than attempting to customise these emails directly, would it possible to turn off email notifications for PR additions and state changes entirely, and instead inject more meaningful comments describing the state change?

@ncoghlan ncoghlan reopened this Apr 1, 2017
@ezio-melotti
Copy link
Member

If you want to continue the discussion I'd suggest moving it to the meta-tracker:
http://psf.upfronthosting.co.za/roundup/meta/issue624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants