Skip to content

Renaming labels on python/cpython #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #13
ezio-melotti opened this issue Mar 24, 2022 · 2 comments · Fixed by python/bedevere#419
Closed
Tracked by #13

Renaming labels on python/cpython #432

ezio-melotti opened this issue Mar 24, 2022 · 2 comments · Fixed by python/bedevere#419
Labels

Comments

@ezio-melotti
Copy link
Member

Some labels of the python/cpython repo should be renamed either before or after the migration:

  • type-enhancement -> type-feature (this has been updated by Guido already)
  • type-bugfix -> type-bug
  • type-documentations -> docs
  • type-tests -> tests
  • type-performance -> performance

This post has some more background, but there are two main things that are relevant for this issue:

  1. making sure there aren't any tools (e.g. bots, actions, etc.) that depend on these specific names and will break if we change them;
  2. making sure that the names match during the migration, or we will end up with two different spellings for the same label;

Labels can be easily renamed before or after the migration, so if you prefer different names you can comment on the post linked above. We can also migrate with these names and updated them later, the only issue is that type-bugfix will look weird on issues, so if we could rename that either before or shortly after the migration it would be better. Please let me know if you want to update any of those labels, so that I can make sure that the same name is used during the migration.

Do you know anything that depends on those names?

(cc: @Mariatta, @brettcannon)

@Mariatta
Copy link
Member

Bedevere relies on those types, so we may need to update it.

https://github.com/python/bedevere/blob/master/bedevere/prtype.py

@Mariatta
Copy link
Member

PR created at bedevere to make use of the new labels.
python/bedevere#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants