Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and document use of the GitHub "Always suggest updating pull request branches" option #434

Closed
ned-deily opened this issue Mar 28, 2022 · 4 comments

Comments

@ned-deily
Copy link
Member

It has been suggested on the Python Core Devs Discord that we should enable the newish GitHub repo option to always suggest updating pull request branches when they are out-of-date when the current branch head. That would simplify the PR contribution experience in the not infrequent case when a PR CI job fails due to some unrelated change that has been subsequently fixed. As an experiment, I've already enabled it for cpython after some discussion on Discord and it does seem to be useful. If we want to make that a permanent change, we should announce it to the developer community and add something to the devguide.

image

@ned-deily
Copy link
Member Author

Pinging admins and other release managers. @brettcannon @Mariatta @pablogsal @ambv

@brettcannon
Copy link
Member

Someone beat me to it!

@ned-deily
Copy link
Member Author

@brettcannon Beat you to what ? :) I changed the setting on the repo before opening the issue. I opened the issue to make sure we had consensus that it was the right thing to do and then, if so, announce it and document it in the devguide. Or do you think that none of that is necessary?

@brettcannon
Copy link
Member

Ah, I thought you were asking me to flip it. The setting is flipping on an unobtrusive feature and I thought it was discussed enough on Discord, so I wasn't worried about more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants