Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconf shell requirements fix #19

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

efimov-mikhail
Copy link
Contributor

@efimov-mikhail efimov-mikhail commented Oct 11, 2024

Problem with autoconf

Rebuilding configure script using /usr/local/bin/autoconf: This script requires a shell more modern than all

in some contexts is fixed with some 'standard' technique.

See https://stackoverflow.com/questions/161064/autoconf-using-sh-i-need-shell-bash-how-do-i-force-autoconf-to-use-bash/161128#161128.

Also LABEL org.opencontainers.image.base.name is changed.
It looks like it was a typo in Dockerfile since FROM value differs from image.base.name.

Unfortunately, these changes are not tested by myself since there is no any build instructions.
Simple
docker build .
fails with an error

The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 871920D1991BC93C

Problem with autoconf
"Rebuilding configure script using /usr/local/bin/autoconf: This script requires a shell more modern than all".
in some contexts is fixed with some 'standard' technique.
See https://stackoverflow.com/questions/161064/autoconf-using-sh-i-need-shell-bash-how-do-i-force-autoconf-to-use-bash/161128#161128.
Copy link
Collaborator

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; looks good to me. I'll let Donghee get a chance to take a look at it before landing.

@corona10 corona10 merged commit ced61c0 into python:main Oct 11, 2024
4 checks passed
@efimov-mikhail efimov-mikhail deleted the autoconf_fix_config_shell branch October 11, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants