Skip to content

Commit

Permalink
IDLE: Fix test_debugger bug and buildbot failures (#112258)
Browse files Browse the repository at this point in the history
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
  • Loading branch information
terryjreedy authored Nov 19, 2023
1 parent adedcfa commit 14fd86a
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions Lib/idlelib/idle_test/test_debugger.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
"Test debugger, coverage 19%"
"""Test debugger, coverage 66%
Try to make tests pass with draft bdbx, which may replace bdb in 3.13+.
"""

from idlelib import debugger
from collections import namedtuple
Expand Down Expand Up @@ -44,10 +47,8 @@ def setUpClass(cls):
cls.msg = 'file.py:2: <module>()'

def test_init(self):
# Test that Idb.__init_ calls Bdb.__init__.
idb = debugger.Idb(None)
self.assertIsNone(idb.gui)
self.assertTrue(hasattr(idb, 'breaks'))
self.assertIs(self.idb.gui, self.gui)
# Won't test super call since two Bdbs are very different.

def test_user_line(self):
# Test that .user_line() creates a string message for a frame.
Expand Down Expand Up @@ -279,6 +280,7 @@ class NameSpaceTest(unittest.TestCase):

@classmethod
def setUpClass(cls):
requires('gui')
cls.root = Tk()
cls.root.withdraw()

Expand Down

0 comments on commit 14fd86a

Please sign in to comment.