Skip to content

Commit

Permalink
gh-110276: No longer ignore PROFILE_TASK failure silently (#110295)
Browse files Browse the repository at this point in the history
  • Loading branch information
vstinner authored Oct 3, 2023
1 parent eeb4e97 commit 6ab6040
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions Doc/using/configure.rst
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,9 @@ also be used to improve performance.

.. versionadded:: 3.8

.. versionchanged:: 3.13
Task failure is no longer ignored silently.

.. cmdoption:: --with-lto=[full|thin|no|yes]

Enable Link Time Optimization (LTO) in any build (disabled by default).
Expand Down
4 changes: 2 additions & 2 deletions Makefile.pre.in
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ profile-run-stamp:
$(MAKE) profile-gen-stamp
# Next, run the profile task to generate the profile information.
@ # FIXME: can't run for a cross build
$(LLVM_PROF_FILE) $(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK) || true
$(LLVM_PROF_FILE) $(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK)
$(LLVM_PROF_MERGER)
# Remove profile generation binary since we are done with it.
$(MAKE) clean-retain-profile
Expand Down Expand Up @@ -706,7 +706,7 @@ profile-bolt-stamp: $(BUILDPYTHON)
mv "$${bin}.bolt_inst" "$${bin}"; \
done
# Run instrumented binaries to collect data.
$(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK) || true
$(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK)
# Merge all the data files together.
for bin in $(BOLT_BINARIES); do \
@MERGE_FDATA@ $${bin}.*.fdata > "$${bin}.fdata"; \
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
No longer ignore :envvar:`PROFILE_TASK` failure silently: command used by
Profile Guided Optimization (PGO). Patch by Victor Stinner.

0 comments on commit 6ab6040

Please sign in to comment.