Skip to content

Commit

Permalink
[3.11] gh-65046: Add note about logging from async code. (GH-97602) (G…
Browse files Browse the repository at this point in the history
  • Loading branch information
miss-islington authored Sep 28, 2022
1 parent c2ec6da commit 73557d5
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Doc/howto/logging-cookbook.rst
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,14 @@ which, when run, will produce:
MainThread: Look out!
.. note:: Although the earlier discussion wasn't specifically talking about
async code, but rather about slow logging handlers, it should be noted that
when logging from async code, network and even file handlers could lead to
problems (blocking the event loop) because some logging is done from
:mod:`asyncio` internals. It might be best, if any async code is used in an
application, to use the above approach for logging, so that any blocking code
runs only in the ``QueueListener`` thread.

.. versionchanged:: 3.5
Prior to Python 3.5, the :class:`QueueListener` always passed every message
received from the queue to every handler it was initialized with. (This was
Expand Down

0 comments on commit 73557d5

Please sign in to comment.