Avoid double search

python · Oct 21, 2022 · a4597b1 · a4597b1
1 parent b26fdb4
commit a4597b1
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/Lib/argparse.py b/Lib/argparse.py
@@ -1542,11 +1542,10 @@ def _get_positional_kwargs(self, dest, **kwargs):
 
  # make sure 'store_true', 'store_false', or 'store_const' action
  # is not specified
- if 'action' in kwargs:
- action = kwargs.get('action')
- if action in ('store_true', 'store_false', 'store_const'):
- msg = _("{action} is an invalid action for positionals", {'action': action})
- raise TypeError(msg)
+ action = kwargs.get('action')
+ if action in ('store_true', 'store_false', 'store_const'):
+ msg = _("{action} is an invalid action for positionals", {'action': action})
+ raise TypeError(msg)
 
  # mark positional arguments as required if at least one is
  # always required