gh-116646, AC: Always use PyObject_AsFileDescriptor() in fildes (#116806

) The fildes converter of Argument Clinic now always call PyObject_AsFileDescriptor(), not only for the limited C API. The _PyLong_FileDescriptor_Converter() converter stays as a fallback when PyObject_AsFileDescriptor() cannot be used.
python · Mar 14, 2024 · a76288a · a76288a
1 parent 2a54c4b
commit a76288a
Show file tree

Hide file tree

Showing 4 changed files with 74 additions and 48 deletions.
diff --git a/Modules/clinic/posixmodule.c.h b/Modules/clinic/posixmodule.c.h
diff --git a/Modules/clinic/selectmodule.c.h b/Modules/clinic/selectmodule.c.h
diff --git a/Modules/clinic/termios.c.h b/Modules/clinic/termios.c.h
diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py
@@ -3832,16 +3832,13 @@ def use_converter(self) -> None:
                          '_PyLong_FileDescriptor_Converter()')
 
     def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> str | None:
-        if limited_capi:
-            return self.format_code("""
-                {paramname} = PyObject_AsFileDescriptor({argname});
-                if ({paramname} < 0) {{{{
-                    goto exit;
-                }}}}
-                """,
-                argname=argname)
-        else:
-            return super().parse_arg(argname, displayname, limited_capi=limited_capi)
+        return self.format_code("""
+            {paramname} = PyObject_AsFileDescriptor({argname});
+            if ({paramname} < 0) {{{{
+                goto exit;
+            }}}}
+            """,
+            argname=argname)
 
 
 class float_converter(CConverter):